More Musig2 followups #798
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This function is useful for Musig but may be useful elsewhere. Rename it to be more general, and mention it in the Musig docs.
I haven't checked against the assembler code and this check is simple enough that I suspect that the compiler is going to undermine me, but the use of ptr::read_volatile *should* prevent that. Anyway make a best-effort attempt.
|
cc @jonasnick |
jonasnick
approved these changes
Jun 11, 2025
|
For those following along -- we quickly PR'd and unceremoniously merged this, but this PR was actually a huge deal. This completes the musig2 implementation in rust-secp! |
|
What's a good place to collect downstream clients with (work-in-progress) MuSig2 support? I'm looking for something, in addition to Ledger, to test interoperability of bitcoin/bitcoin#29675 against. |
|
That's a great question, but I don't know the answer. |
chain-forgexcr45
added a commit
to chain-forgexcr45/rust-secp256k1
that referenced
this pull request
Sep 28, 2025
480370c6f87a5ee45bbea16df803a256e8bd435e ci: disable broken WASM and cross tests (Andrew Poelstra)
98bfb48b001002490e8a96d845fa21b05a2312f2 musig: make zero-check in SessionSecretRand::assume_unique constant time (Andrew Poelstra)
d318169a7c2d0d2cb3c96d61ae04bfd044c19b23 musig: rename `musig_sort_pubkeys` to just `sort_pubkeys` (Andrew Poelstra)
fdae0fd55eb5673bd5df1298f4594137bbfc4f2b typo: leak -> lead (Andrew Poelstra)
Pull request description:
Addresses review comments from #794, and also disables a couple broken CI jobs.
ACKs for top commit:
jonasnick:
ACK 480370c6f87a5ee45bbea16df803a256e8bd435e
Tree-SHA512: 33e4849389fcefb9916a1dcb5234497a42aa9759f81b4954cac85002a26f1d763ddc5b5c38c62795be339b84ffdb3544c6b3e7408ef8d95b67289fd697d5f1e1
william2332-limf
added a commit
to william2332-limf/rust-secp256k1
that referenced
this pull request
Oct 2, 2025
480370c6f87a5ee45bbea16df803a256e8bd435e ci: disable broken WASM and cross tests (Andrew Poelstra)
98bfb48b001002490e8a96d845fa21b05a2312f2 musig: make zero-check in SessionSecretRand::assume_unique constant time (Andrew Poelstra)
d318169a7c2d0d2cb3c96d61ae04bfd044c19b23 musig: rename `musig_sort_pubkeys` to just `sort_pubkeys` (Andrew Poelstra)
fdae0fd55eb5673bd5df1298f4594137bbfc4f2b typo: leak -> lead (Andrew Poelstra)
Pull request description:
Addresses review comments from #794, and also disables a couple broken CI jobs.
ACKs for top commit:
jonasnick:
ACK 480370c6f87a5ee45bbea16df803a256e8bd435e
Tree-SHA512: 33e4849389fcefb9916a1dcb5234497a42aa9759f81b4954cac85002a26f1d763ddc5b5c38c62795be339b84ffdb3544c6b3e7408ef8d95b67289fd697d5f1e1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses review comments from #794, and also disables a couple broken CI jobs.